Don't build universal binaries for macOS / iOS when dev_build=yes, to save on dev build time#1613
Don't build universal binaries for macOS / iOS when dev_build=yes, to save on dev build time#1613Ivorforce wants to merge 1 commit intogodotengine:masterfrom
Conversation
… save on dev build time.
dsnopek
left a comment
dsnopek
left a comment
There was a problem hiding this comment.
Does this match what Godot's build system does?
If not, I'd be reluctant to do that in godot-cpp. It's really just saving you from having to additionally specify arch=arm64, which doesn't seem too onerous.
|
As far as I can see, godot is not capable of building universal at all. I think they must build the two arches separately and join them together after the build. Edit: Confirmed, at least the GitHub runner runs them separately and then: |
|
Ah, ok, so we're doing something totally different than Godot. :-/ I guess we'll need to decide if we want to switch to matching Godot, update Godot to match godot-cpp, or decide if we have a compelling argument to differ from Godot. This is probably worth discussing at an upcoming GDExtension meeting. |
|
Switching to a built-twice-then-join approach may actually be better in more ways than just feature parity. I've run into the problem already that passing arch-specific flags (like |
|
Making this a draft because it may be superseded by #1633. |
2 participants
This change just about halves my build time (godot-cpp as an example):
universalx86_64Unsurprisingly, it also halves my build size:
universalx86_64While I agree that macOS export default should be
universal, in dev mode it would be better to default to single arch.